[main] Update dependencies from dotnet/arcade

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

• Subscription: 111cfc79-5f9f-4acd-d8a2-08dc0c5899fd
• Build: 20240213.2
• Date Produced: February 13, 2024 8:30:17 PM UTC
• Commit: da98edc4c3ea539f109ea320672136ceb32591a7
• Branch: refs/heads/release/8.0

• Updates:
  • Microsoft.SourceBuild.Intermediate.arcade: from 8.0.0-beta.24059.4 to 8.0.0-beta.24113.2
  • Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.24059.4 to 8.0.0-beta.24113.2
  • Microsoft.DotNet.Helix.Sdk: from 8.0.0-beta.24059.4 to 8.0.0-beta.24113.2

[ghost]

This PR changes the .NET SDK version. Review required from @dotnet/roslyn-infrastructure-current-swat before merging.
Tasks:

• Getting Started Documentation has been updated
• NuGet dependency version updated to match version shipping in SDK

[jjonescz]

@dotnet/source-build-internal It looks like the Regex source generator is not running here during source build (it works in main where SDK is v8.0.100, and doesn't work here where SDK is v8.0.101). Do you know what might be the problem? Thanks.

[mthalman]

@dotnet/source-build-internal It looks like the Regex source generator is not running here during source build (it works in main where SDK is v8.0.100, and doesn't work here where SDK is v8.0.101). Do you know what might be the problem? Thanks.

I don't know why that would happen. You can try to diagnose this by running source build locally with ./build.sh --sourcebuild.

[jasonmalinowski]

Yeah I have no idea why that would be broken.

[jjonescz]

Cannot repro it locally, the build succeeds for me. I compared binlog from this PR with binlog from main - the Microsoft.NETCore.App targeting pack is not getting located in this PR (in main it has PackageDirectory = /__w/1/s/.dotnet/packs/Microsoft.NETCore.App.Ref/8.0.0 which is missing in this PR's binlog) and is instead then downloaded from NuGet (into /__w/1/s/artifacts/source-build/self/package-cache/microsoft.netcore.app.ref/8.0.0) but that doesn't contain the source generators.

[mthalman]

Ok, I think I know what's going on. This is a bit of a problem. The Microsoft.NETCore.App.Ref targeting pack is getting loaded from SBRP. This is meant to be a reference assembly (no implementation) so it doesn't include things like Roslyn analyzers and now, apparently, source generators.

@MichaelSimons - Can you weigh in here? Does this essentially mean that any repo source which is participating in source build can't take a dependency on source generators when targeting an older SDK version?

[MichaelSimons]

@MichaelSimons - Can you weigh in here? Does this essentially mean that any repo source which is participating in source build can't take a dependency on source generators when targeting an older SDK version?

Yes, that's correct. If you want source generators/analyzers, you must target NetCurrent for source-build.

[jjonescz]

I don't understand. Are you talking about target framework or SDK version?

• Looking at binlog, NetCurrent=net8.0 and the failing source build has TargetFramework=net8.0.
• I don't know why 8.0.0 of the ref package is used when SDK is set to 8.0.101 (I would expect 8.0.1 of the ref package to get used).

[mthalman]

Ah, it's because of this:

roslyn/eng/targets/Imports.BeforeArcade.targets

Lines 17 to 24 in 3472dcb

	<ItemGroup Condition="'$(DotNetBuildFromSource)' == 'true'">
	<KnownFrameworkReference Update="Microsoft.NETCore.App">
	<TargetingPackVersion Condition="'%(TargetFramework)' == 'net8.0'">8.0.0</TargetingPackVersion>
	</KnownFrameworkReference>
	<KnownFrameworkReference Update="Microsoft.AspNetCore.App">
	<TargetingPackVersion Condition="'%(TargetFramework)' == 'net8.0'">8.0.0</TargetingPackVersion>
	</KnownFrameworkReference>
	</ItemGroup>

So yes, it is using the 8.0.101 SDK which sets the targeting pack version of Microsoft.NETCore.App to 8.0.1. But then the snippet above changes that to be 8.0.0 which causes it to load from SBRP instead (since that's where it's available). I question the need for that snippet at all. For roslyn source build, we'll want it to use the Microsoft built targeting pack: 8.0.1. For the VMR build of roslyn, we want it to be targeting the current version of the targeting pack anyway. So in both cases, the snippet above is not what is needed. Removing it would cause a prebuilt for Microsoft.NETCore.App.8.0.1 in the roslyn build but that can be added to the prebuilt baseline since the prebuilt wouldn't occur in the VMR build. Looking back at 8.0 of the VMR, this snippet also wasn't relevant since it was set to net6.0: https://github.com/dotnet/dotnet/blob/4e65e09544821be37c52624fc60278d9dd05cc6d/src/roslyn/eng/targets/Imports.BeforeArcade.targets#L17-L24.

@MichaelSimons - Does my assessment seem correct to you?

[MichaelSimons]

Ah, it's because of this:

roslyn/eng/targets/Imports.BeforeArcade.targets

Lines 17 to 24 in 3472dcb

	<ItemGroup Condition="'$(DotNetBuildFromSource)' == 'true'">
	<KnownFrameworkReference Update="Microsoft.NETCore.App">
	<TargetingPackVersion Condition="'%(TargetFramework)' == 'net8.0'">8.0.0</TargetingPackVersion>
	</KnownFrameworkReference>
	<KnownFrameworkReference Update="Microsoft.AspNetCore.App">
	<TargetingPackVersion Condition="'%(TargetFramework)' == 'net8.0'">8.0.0</TargetingPackVersion>
	</KnownFrameworkReference>
	</ItemGroup>

So yes, it is using the 8.0.101 SDK which sets the targeting pack version of Microsoft.NETCore.App to 8.0.1. But then the snippet above changes that to be 8.0.0 which causes it to load from SBRP instead (since that's where it's available). I question the need for that snippet at all. For roslyn source build, we'll want it to use the Microsoft built targeting pack: 8.0.1. For the VMR build of roslyn, we want it to be targeting the current version of the targeting pack anyway. So in both cases, the snippet above is not what is needed. Removing it would cause a prebuilt for Microsoft.NETCore.App.8.0.1 in the roslyn build but that can be added to the prebuilt baseline since the prebuilt wouldn't occur in the VMR build. Looking back at 8.0 of the VMR, this snippet also wasn't relevant since it was set to net6.0: https://github.com/dotnet/dotnet/blob/4e65e09544821be37c52624fc60278d9dd05cc6d/src/roslyn/eng/targets/Imports.BeforeArcade.targets#L17-L24.

@MichaelSimons - Does my assessment seem correct to you?

I agree with this assessment.

Docs mention to use global.json version, so no need to update. The other point I don't understand but if it means updating MicrosoftNetCompilersToolsetVersion than that's already at newer version than in SDK.