Avoid synthesizing the parameterless struct constructor unnecessarily #72314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
RikkiGibson
reviewed
Feb 28, 2024
| "S..ctor(System.Int32 p)", | ||
| "S..ctor()"); | ||
| VerifyExplicitlyDeclaredInstanceConstructors( | ||
| ((Compilation)comp).GlobalNamespace.GetTypeMember("S"), |
There was a problem hiding this comment.
What is the difference when obtaining the type symbol in this way, versus without the cast?
There was a problem hiding this comment.
The symbols from Compilation are public API ISymbol, while the symbols from CSharpCompilation are internal Symbol. Since the ISymbol instances are generated from the Symbol instances, this additional test may not be that useful, but it seemed simple to include.
RikkiGibson
approved these changes
Feb 28, 2024
|
nit: In future please link to the bug which the PR is solving the PR description (even if the bug is internal). Makes it a little easier to understand the goals/context of the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameterless struct constructor was synthesized unnecessarily if other instance constructors and a
staticconstructor were declared before the parameterless constructor. The result was duplicate, ambiguous parameterless constructors.