Remove more usages of specialized collections in favor of collection exprs #72918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
ToddGrun
reviewed
Apr 7, 2024
src/Workspaces/CSharp/Portable/CodeGeneration/CSharpSyntaxGenerator.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Apr 8, 2024
| @@ -31,7 +31,7 @@ internal static DeclarationInfo GetDeclarationInfo(SemanticModel model, SyntaxNo | |||
|
|
|||
| internal static DeclarationInfo GetDeclarationInfo(SemanticModel model, SyntaxNode node, bool getSymbol, SyntaxNode executableCodeBlock, CancellationToken cancellationToken) | |||
| { | |||
| return GetDeclarationInfo(model, node, getSymbol, SpecializedCollections.SingletonEnumerable(executableCodeBlock), cancellationToken); | |||
| return GetDeclarationInfo(model, node, getSymbol, [executableCodeBlock], cancellationToken); | |||
There was a problem hiding this comment.
We generally do not welcome changes like this under Compilers.
|
Odd. This wasn't meant to touch the compiler. Will revert. |
sharwell
reviewed
Apr 8, 2024
| @@ -71,7 +71,7 @@ public static ICollection<ISymbol> GetMissingEnumMembers(ISwitchOperation switch | |||
| if (!TryGetAllEnumMembers(switchExpressionType, enumMembers) || | |||
| !TryRemoveExistingEnumMembers(switchStatement, enumMembers)) | |||
| { | |||
| return SpecializedCollections.EmptyCollection<ISymbol>(); | |||
| return []; | |||
There was a problem hiding this comment.
❓ What type gets constructed for this case? I would expect this change introduced a new allocation due to the return type.
sharwell
reviewed
Apr 8, 2024
| { | ||
| return SpecializedCollections.EmptyList<TextChange>(); | ||
| } | ||
| return []; |
There was a problem hiding this comment.
| @@ -35,7 +35,7 @@ public IList<ClassificationSpan> GetClassificationSpans(SnapshotSpan span) | |||
| return classifications.Where(c => c.Span.IntersectsWith(span)).ToList(); | |||
| } | |||
|
|
|||
| return SpecializedCollections.EmptyList<ClassificationSpan>(); | |||
| return []; | |||
There was a problem hiding this comment.
| @@ -55,7 +55,7 @@ public IList<ClassificationSpan> GetClassificationSpans(SnapshotSpan span) | |||
| } | |||
| } | |||
|
|
|||
| return SpecializedCollections.EmptyList<ClassificationSpan>(); | |||
| return []; | |||
There was a problem hiding this comment.
| @@ -97,7 +97,7 @@ private static IList<ITextView> GetTextViews(ITextBuffer textBuffer) | |||
| { | |||
| if (!s_map.TryGetValue(textBuffer, out var set)) | |||
| { | |||
| return SpecializedCollections.EmptyList<ITextView>(); | |||
| return []; | |||
There was a problem hiding this comment.
| @@ -632,7 +632,7 @@ private void LogRenameSession(RenameLogMessage.UserActionOutcome outcome, bool p | |||
| outcome, | |||
| conflictResolutionFinishedComputing, | |||
| previewChanges, | |||
| SpecializedCollections.EmptyList<InlineRenameReplacementKind>())); | |||
| replacementKinds: [])); | |||
There was a problem hiding this comment.
| @@ -269,7 +269,7 @@ private static IList<string> CollectLogHubFilePaths() | |||
| // ignore failures | |||
| } | |||
|
|
|||
| return SpecializedCollections.EmptyList<string>(); | |||
| return []; | |||
There was a problem hiding this comment.
| @@ -84,7 +84,7 @@ public IList<TextChange> FormatToken(SyntaxToken token, CancellationToken cancel | |||
| if (previousToken.Kind() == SyntaxKind.None) | |||
| { | |||
| // no previous token. nothing to format | |||
| return SpecializedCollections.EmptyList<TextChange>(); | |||
| return []; | |||
There was a problem hiding this comment.
| @@ -52,7 +50,7 @@ public IFormattingResult GetFormattingResult(SyntaxNode node, IEnumerable<TextSp | |||
|
|
|||
| if (spansToFormat.Count == 0) | |||
| { | |||
| return CreateAggregatedFormattingResult(node, SpecializedCollections.EmptyList<AbstractFormattingResult>()); | |||
| return CreateAggregatedFormattingResult(node, results: []); | |||
There was a problem hiding this comment.
| @@ -72,7 +70,7 @@ public IFormattingResult GetFormattingResult(SyntaxNode node, IEnumerable<TextSp | |||
| // quick simple case check | |||
| if (results == null) | |||
| { | |||
| return CreateAggregatedFormattingResult(node, SpecializedCollections.EmptyList<AbstractFormattingResult>()); | |||
| return CreateAggregatedFormattingResult(node, results: []); | |||
There was a problem hiding this comment.
| return info == null | ||
| ? SpecializedCollections.EmptyList<ISymbol>() | ||
| : info._imports; | ||
| return info == null ? [] : info._imports; |
There was a problem hiding this comment.
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.