Change all messages to pass back their checksum. Switch to callback style #73015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than what is in the asset cache
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 14, 2024
|
|
||
| // We flush after each item as that forms a reasonably sized chunk of data to want to then send over the | ||
| // pipe for the reader on the other side to read. This allows the item-writing to remain entirely | ||
| // synchronous without any blocking on async flushing, while also ensuring that we're not buffering the | ||
| // entire stream of data into the pipe before it gets sent to the other side. | ||
| WriteAsset(writer, serializer, context, asset, cancellationToken); |
There was a problem hiding this comment.
inliend this method.
CyrusNajmabadi
commented
Apr 14, 2024
|
|
||
| await RequestAssetsAsync( |
There was a problem hiding this comment.
inlined this method call.
This was referenced Apr 16, 2024
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #73013 to help keep that PR simpler.