Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial properties: misc compiler layer work #73527

Merged
merged 11 commits into from
May 20, 2024
Merged

Partial properties: misc compiler layer work #73527

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
41537a9
Doc comments
RikkiGibson May 15, 2024
f22f08d
extern scenarios
RikkiGibson May 16, 2024
9bfeade
cleanup prototypes. add compilation events test.
RikkiGibson May 16, 2024
6a79b2e
Check LangVersion
RikkiGibson May 16, 2024
b2e714a
fix MessageID.RequiredVersion
RikkiGibson May 17, 2024
950eca1
Fix doc comment tests
RikkiGibson May 17, 2024
ff5ea82
Fix extern tests on net472
RikkiGibson May 17, 2024
5912984
Test doc comment cases for decl without impl
RikkiGibson May 20, 2024
9eb3524
Address feedback
RikkiGibson May 20, 2024
c085c3f
Address feedback
RikkiGibson May 20, 2024
33cc9c0
Apply suggestions from code review
RikkiGibson May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@RikkiGibson
RikkiGibson committed May 20, 2024
commit 33cc9c07f847125b96ff8a20f1cde4956f2e516c
4 changes: 2 additions & 2 deletions src/Compilers/CSharp/Test/Symbol/Symbols/PartialPropertiesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,7 @@ partial class C
Diagnostic(ErrorCode.ERR_DuplicateNameInClass, "P").WithArguments("C", "P").WithLocation(4, 24)
);

var members = comp.GetMembers<SourcePropertySymbol>("C.P");
var members = comp.GetMembers("C.P").SelectAsArray(m => (SourcePropertySymbol)m);
Assert.Equal(2, members.Length);
Assert.True(members[0].IsExtern);
Assert.True(members[0].IsPartialImplementation);
Expand Down Expand Up @@ -4431,7 +4431,7 @@ partial class C
}
""";

var comp = CreateCompilation(source, parseOptions.TestOptions.RegularNext);
var comp = CreateCompilation(source, parseOptions: TestOptions.RegularNext);
comp.VerifyEmitDiagnostics();

comp = CreateCompilation(source, parseOptions: TestOptions.Regular12);
Expand Down