Switch to a simpler algorithm for placing hte interval tree array elements. #73868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
3 tasks
CyrusNajmabadi
commented
Jun 6, 2024
| @@ -416,4 +416,31 @@ public void TestProperBalancing() | |||
| AssertEx.Equal(tree, Enumerable.Range(1, i)); | |||
| } | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void TestVeryLargeBalancing() | |||
There was a problem hiding this comment.
i wnated tests that also validated the edge cases in large trees to ensure the math was scaling up properly.
CyrusNajmabadi
commented
Jun 6, 2024
| { | ||
| for (var i = 10; i < 20; i++) | ||
| { | ||
| var totalCount = 1 << i; |
There was a problem hiding this comment.
trees up to 1m elements in size.
ToddGrun
reviewed
Jun 6, 2024
...Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/FlatArrayIntervalTree`1.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Jun 6, 2024
...Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/FlatArrayIntervalTree`1.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Jun 6, 2024
...Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/FlatArrayIntervalTree`1.cs
Outdated
Show resolved
Hide resolved
…ections/FlatArrayIntervalTree`1.cs
CyrusNajmabadi
commented
Jun 6, 2024
...Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/FlatArrayIntervalTree`1.cs
Outdated
Show resolved
Hide resolved
…ections/FlatArrayIntervalTree`1.cs
ToddGrun
reviewed
Jun 6, 2024
| BuildCompleteTreeRecursive(source, destination, midPoint + 1, endExclusive, GetRightChildIndex(destinationIndex)); | ||
| // The total tree height. If we're perfect, it's the height of the perfect portion. Otherwise | ||
| // it's one higher (to fit the remaining incomplete row). | ||
| var treeHeight = isPerfect ? perfectPortionHeight : perfectPortionHeight + 1; |
There was a problem hiding this comment.
will do in followup.
ToddGrun
reviewed
Jun 6, 2024
|
|
||
| // Here we can figure out which case we have, and where the pivot it. First, we start with | ||
| // | ||
| // 1. `a = subtreeNodeCount - perfectSectionNodeCount`. The number of elements in the 'incomplete' last row. |
There was a problem hiding this comment.
will do in followup.
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.