Fix issue with 'use explicit cast' and compound assignments #74225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jul 1, 2024
| SemanticModel semanticModel, ExpressionSyntax targetNode, ITypeSymbol conversionType) | ||
| { | ||
| // The compiler is very ambiguous with assignment expressions `(a += b)`. An error on it may be an error on the | ||
| // entire expression or on the RHS of the assignment. Have to reverse engineer what it is doing here. |
There was a problem hiding this comment.
this is the main fix.
CyrusNajmabadi
commented
Jul 1, 2024
| /// </summary> | ||
| private const int MaximumConversionOptions = 3; | ||
|
|
||
| protected abstract TExpressionSyntax Cast(TExpressionSyntax expression, ITypeSymbol type); | ||
| protected abstract void GetPartsOfCastOrConversionExpression(TExpressionSyntax expression, out SyntaxNode type, out SyntaxNode castedExpression); | ||
| protected abstract void GetPartsOfCastOrConversionExpression(TExpressionSyntax expression, out SyntaxNode type, out TExpressionSyntax castedExpression); |
CyrusNajmabadi
commented
Jul 1, 2024
| using var _ = ArrayBuilder<(TExpressionSyntax node, ITypeSymbol type)>.GetInstance(out var candidates); | ||
|
|
||
| this.AddPotentialTargetTypes(document, semanticModel, root, diagnosticId, spanNode, candidates, cancellationToken); | ||
| candidates.RemoveDuplicates(); |
There was a problem hiding this comment.
sharing common code between C# and VB
|
@akhera99 ptal :) |
ToddGrun
reviewed
Jul 1, 2024
| this.Cast((TExpressionSyntax)castedExpression, conversionType) | ||
| .WithTriviaFrom(targetNode) | ||
| .WithAdditionalAnnotations(Simplifier.Annotation)); | ||
| var firstConversion = semanticFacts.ClassifyConversion(semanticModel, castedExpression, castType); |
There was a problem hiding this comment.
nit: could move the def of semanticFacts to here
There was a problem hiding this comment.
yup. though i'm ok with this.
ToddGrun
approved these changes
Jul 1, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56141.