Skip to content

Commit

Permalink
Fix conditions to bin place msquic.dll for Windows builds. (#81492)
Browse files Browse the repository at this point in the history
Co-authored-by: Marie Píchová <mapichov@microsoft.com>
  • Loading branch information
github-actions[bot] and ManickaP authored Feb 1, 2023
1 parent 3518cee commit 554b2c7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/libraries/System.Net.Quic/src/System.Net.Quic.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@
<!-- Support for deploying msquic on Windows -->
<ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'windows' and
'$(TargetOS)' == 'windows' and
'$(UseQuicTransportPackage)' == 'true' and
'$(DotNetBuildFromSource)' != 'true'">
<BinPlaceDir Include="$(MicrosoftNetCoreAppRuntimePackNativeDir)" ItemName="NativeBinPlaceItem" />
<BinPlaceDir Include="$(NetCoreAppCurrentTestHostSharedFrameworkPath)" ItemName="NativeBinPlaceItem" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,12 @@ public void UnsupportedPlatforms_ThrowsPlatformNotSupportedException()
Assert.ThrowsAsync<PlatformNotSupportedException>(async () => await CreateQuicListener());
Assert.ThrowsAsync<PlatformNotSupportedException>(async () => await CreateQuicConnection(new IPEndPoint(IPAddress.Loopback, 0)));
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.SupportsTls13))]
public void SupportedWindowsPlatforms_IsSupportedIsTrue()
{
Assert.True(QuicListener.IsSupported);
Assert.True(QuicConnection.IsSupported);
}
}
}

0 comments on commit 554b2c7

Please sign in to comment.