Skip to content

Commit

Permalink
Add automatic SDL validation (dotnet/core-setup#8846)
Browse files Browse the repository at this point in the history
Commit migrated from dotnet/core-setup@130c63e
  • Loading branch information
dagood committed Nov 14, 2019
1 parent e68194a commit f27dc36
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
2 changes: 2 additions & 0 deletions eng/pipelines/installer/azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ variables:
- ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
- name: SignType
value: $[ coalesce(variables.OfficialSignType, 'real') ]
# Values for SDLValidationParameters
- group: core-setup-sdl-validation

- ${{ if contains(variables['Build.DefinitionName'], 'runtime') }}:
- name: pipelinesPath
Expand Down
17 changes: 17 additions & 0 deletions eng/pipelines/installer/stages/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,23 @@ stages:
# Allow symbol publish to emit expected warnings without failing the build. Include single
# quotes inside the string so that it passes through to MSBuild without script interference.
symbolPublishingAdditionalParameters: "'-warnAsError:$false'"
# Enable SDL validation, passing through values from the 'core-setup-sdl-validation' group.
SDLValidationParameters:
enable: true
artifactNames:
- PackageArtifacts
- BlobArtifacts
params: >-
-SourceToolsList @("policheck","credscan")
-TsaInstanceURL "$(TsaInstanceURL)"
-TsaProjectName "$(TsaProjectName)"
-TsaNotificationEmail "$(TsaNotificationEmail)"
-TsaCodebaseAdmin "$(TsaCodebaseAdmin)"
-TsaBugAreaPath "$(TsaBugAreaPath)"
-TsaIterationPath "$(TsaIterationPath)"
-TsaRepositoryName "$(TsaRepositoryName)"
-TsaCodebaseName "$(TsaCodebaseName)"
-TsaPublish $True
# Create extra stage per BAR channel that needs extra publish steps. These run after the Arcade
# stages because they depend on Arcade's NuGet package publish being complete.
Expand Down

0 comments on commit f27dc36

Please sign in to comment.