Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64/Sve: Remove HW_Flag_HasEnumOperand #105702

Closed
a74nh opened this issue Jul 30, 2024 · 5 comments
Closed

Arm64/Sve: Remove HW_Flag_HasEnumOperand #105702

a74nh opened this issue Jul 30, 2024 · 5 comments
Assignees
@a74nh
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:3 Work that is nice to have
Milestone
10.0.0

Comments

@a74nh
Copy link
Contributor

a74nh commented Jul 30, 2024

HW_Flag_HasEnumOperand flag was added to distinguish between enums and immediates. However, the code treats them both the same.

Remove HW_Flag_HasEnumOperand and always use HW_Flag_HasImmediateOperand instead. It is taking up valuable space in the enum.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 30, 2024
@a74nh a74nh added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Priority:3 Work that is nice to have arm-sve Work related to arm64 SVE/SVE2 support and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 30, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@a74nh a74nh added this to the 9.0.0 milestone Jul 30, 2024
@a74nh
Copy link
Contributor Author

a74nh commented Jul 30, 2024

priority:3 for RC1 snap : Code cleanup. Nice to have for the future because we are running out of spaces in the enum.

@a74nh
Copy link
Contributor Author

a74nh commented Jul 30, 2024

Whilst doing this, please tidy up the HWIntrinsicFlag enum. It has multiple sections for each target.
It needs re-ordering.

@a74nh a74nh self-assigned this Aug 12, 2024
@a74nh a74nh modified the milestones: 9.0.0, 10.0.0 Aug 12, 2024
@a74nh a74nh mentioned this issue Aug 20, 2024
Merged
@a74nh
Copy link
Contributor Author

a74nh commented Aug 20, 2024

Fixed by #106622

1 similar comment
@a74nh
Copy link
Contributor Author

a74nh commented Aug 20, 2024

Fixed by #106622

@a74nh a74nh closed this as completed Aug 20, 2024
@a74nh a74nh added the in-pr There is an active PR which will close this issue when it is merged label Aug 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@a74nh a74nh

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:3 Work that is nice to have
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
1 participant
@a74nh