ARM64-SVE: Remove HW_Flag_HasEnumOperand #105702 #106622
Merged
+89
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag is not required - HW_Flag_HasImmediateOperand can be used instead. Also, reorder the flags enum.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
a74nh
changed the title
|
@dotnet/arm64-contrib @kunalspathak. A quick cleanup. |
|
Fixes #105702 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag is not required - HW_Flag_HasImmediateOperand can be used instead.
Also, reorder the flags enum.
Ran stress testing. Found #106621, but it's not related to this PR. Otherwise all pass.
I also think the
emitIns_R_PATTERNshould be merged intoemitIns_R_I, andemitIns_R_PATTERN_IintoemitIns_R_I_I, but that's for a later PR.