Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source generators are not shipping symbols #107421

Closed
hoyosjs opened this issue Sep 5, 2024 · 1 comment · Fixed by dotnet/arcade#15052
Closed

Source generators are not shipping symbols #107421

hoyosjs opened this issue Sep 5, 2024 · 1 comment · Fixed by dotnet/arcade#15052
Labels
area-Infrastructure-libraries
Milestone
9.0.0

Comments

@hoyosjs
Copy link
Member

hoyosjs commented Sep 5, 2024 •
edited
Loading

Source generators and analyzers that only ship in the Ref pack currently don't have any symbols. Since the shared framework SDK removes all symbol files

https://github.com/dotnet/arcade/blob/fd7ca2e0fea477f189d7871abec632f2a832d532/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L159

we end up with no way index them.
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Sep 5, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@hoyosjs hoyosjs added this to the 9.0.0 milestone Sep 5, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Sep 5, 2024
hoyosjs added a commit to dotnet/arcade that referenced this issue Sep 6, 2024
@hoyosjs
Pack analyzer symbols in ref pack symbol packages
304bee4 
Analyzers only get used in build time - ship their symbols with the symbol package for the targeting pack. Fixes dotnet/runtime#107421
@hoyosjs hoyosjs mentioned this issue Sep 6, 2024
Merged
github-actions bot pushed a commit to dotnet/arcade that referenced this issue Sep 7, 2024
@hoyosjs
Pack analyzer symbols in ref pack symbol packages
c35d6f3 
Analyzers only get used in build time - ship their symbols with the symbol package for the targeting pack. Fixes dotnet/runtime#107421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Pack analyzer symbols in ref pack symbol packages dotnet/arcade
1 participant
@hoyosjs