Cache more info on HttpMethod #100177
Merged
Cache more info on HttpMethod #100177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Mar 23, 2024
src/libraries/System.Net.Http/src/System/Net/Http/HttpMethod.SocketsHttpHandler.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Mar 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already caching the encoded bytes for HTTP/3. This extends that to H1 and H2.
I also precomputed things like
MustHaveRequestBodyto avoid some branches on the hot path.Instead of trying to get the normalized method on each request, that logic is now in the cold path if encoded bytes aren't available yet.
Save a couple ns per request, and 8 bytes off of the H1 state machine allocation (no more
normalizedMethod).