Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] rename WasmTestOnChrome #101140

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 16, 2024

  • WasmTestOnBrowser -> WasmTestOnChrome
  • normal -> WasmTestOnWasmtime
  • BROWSER_PATH_FOR_TESTS -> CHROME_PATH_FOR_TESTS or FIREFOX_PATH_FOR_TESTS
  • _WasmBrowserPathForTests -> _WasmChromePathForTests or _WasmFirefoxPathForTests
  • drop WasmRunnerAOTTemplate.sh and move _buildAOTFunc() to WasmRunnerTemplate.sh
  • drop WasiRunnerAOTTemplate.sh and move _buildAOTFunc() to WasiRunnerTemplate.sh
  • added $(TestArchiveRoot)chromeonly
  • added $(TestArchiveRoot)wasmtimeonly
  • renamed ChromeVersions.props -> BrowserVersions.props

Copy link
Contributor

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara marked this pull request as ready for review April 17, 2024 11:05
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

pavelsavara and others added 3 commits April 17, 2024 14:40
Co-authored-by: Marek Fišera <mara@neptuo.com>
# Conflicts:
#	eng/testing/tests.browser.targets
#	src/libraries/sendtohelix-browser.targets
#	src/mono/wasm/Wasm.Build.Tests/Common/EnvironmentVariables.cs
#	src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj
@pavelsavara
Copy link
Member Author

/ba-g CI failures are known

@pavelsavara pavelsavara merged commit 9068070 into dotnet:main Apr 18, 2024
162 of 168 checks passed
@pavelsavara pavelsavara deleted the WasmTestOnChrome branch April 18, 2024 07:52
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
Co-authored-by: Marek Fišera <mara@neptuo.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants