disable new EH on win-arm64 #102052
Merged
disable new EH on win-arm64 #102052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 |
jeffschwMSFT
reviewed
May 9, 2024
|
/backport to release/8.0-staging (Sorry wrong backport) |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9023891273 |
|
@mangod9 backporting to release/8.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: disable new EH on win-arm64
.git/rebase-apply/patch:13: trailing whitespace.
#if defined(HOST_WINDOWS) && defined(TARGET_ARM64)
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M src/coreclr/inc/clrconfigvalues.h
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/inc/clrconfigvalues.h
CONFLICT (content): Merge conflict in src/coreclr/inc/clrconfigvalues.h
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 disable new EH on win-arm64
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@mangod9 an error occurred while backporting to release/8.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
|
/backport to release/9.0-preview4 |
|
Started backporting to release/9.0-preview4: https://github.com/dotnet/runtime/actions/runs/9023912075 |
4 tasks
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround to fix an SDK issue on windows arm64. This will disable new Exception Handling for this platform while we investigate the issue.