-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reflection from FrameworkDescription #102164
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c398549
Remove reflection from FrameworkDescription
am11 0bbf65b
Remove prerelease tests
am11 db1420d
Switch to source gen
am11 c1ce415
Address CR feedback
am11 bd4f66e
Update src/libraries/System.Private.CoreLib/gen/ProductVersionInfoGen…
am11 4165c9c
Fix build
am11 a031659
Merge branch 'main' into feature/versioning/cleanups
jkotas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
src/libraries/System.Private.CoreLib/gen/DotnetProductVersionInfoGenerator.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System; | ||
using System.Collections.Immutable; | ||
using System.IO; | ||
using Microsoft.CodeAnalysis; | ||
|
||
namespace Generators | ||
{ | ||
[Generator] | ||
public partial class DotnetProductVersionInfoGenerator : IIncrementalGenerator | ||
{ | ||
public void Initialize(IncrementalGeneratorInitializationContext context) | ||
{ | ||
// we only care about filename which is of the form "$(Version).versionstring", no need to actually read the file. | ||
IncrementalValuesProvider<AdditionalText> textFiles = context.AdditionalTextsProvider.Where(static file => file.Path.EndsWith(".versionstring")); | ||
IncrementalValueProvider<(Compilation Left, ImmutableArray<AdditionalText> Right)> compilationAndFiles = | ||
context.CompilationProvider.Combine(textFiles.Collect()); | ||
|
||
context.RegisterSourceOutput(compilationAndFiles, (spc, content) => | ||
{ | ||
// strip semver metadata (git hash) followed by + sign | ||
string? productVersion = Path.GetFileNameWithoutExtension(content.Right[0].Path.Split('+')?[0]); | ||
|
||
if (productVersion is null) | ||
throw new InvalidOperationException($"Unable to get product version at build time."); | ||
|
||
spc.AddSource("Environment.DotnetProductVersionInfo.g.cs", $@" | ||
// <auto-generated/> | ||
|
||
namespace System; | ||
|
||
public static partial class Environment | ||
{{ | ||
internal const string ProductVersionWithLabel = ""{productVersion}""; | ||
private const string ProductVersionWithoutLabel = ""{productVersion.Split('-')?[0]}""; | ||
}}"); | ||
}); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 4 additions & 25 deletions
29
...libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/RuntimeInformation.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note,
<TargetFramework>netstandard2.0</TargetFramework>
this can probably use$(NetCoreAppCurrent)
as it is only used by corelib building for current version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be cases where the generator runs on .NET Framework if people open the project in Visual Studio.