ILLink: Add test for event warning origin issue #102405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
sbomer
approved these changes
May 21, 2024
There was a problem hiding this comment.
Thanks! Note there are a few existing tests that aren't explicitly written for this, but hit the bug: https://github.com/search?q=repo%3Adotnet%2Fruntime%20https%3A%2F%2Fgithub.com%2Fdotnet%2Fruntime%2Fissues%2F100499&type=code
This was referenced May 23, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Marking of events was a little weird in the trimmer. Previously, if any method is marked, all methods will be marked, but the other methods will be marked as a dependency of the first marked event method. This leads to warnings for the add method showing up on the remove method if the remove method is the only one referenced in the method body. The behavior has been fixed, but this commit adds a test for regression on this behavior.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking of events is a little weird in the trimmer. If any method is marked, all methods will be marked, but the other methods will be marked as a dependency of the first marked event method. This leads to warnings for the
addmethod showing up on theremovemethod if theremovemethod is the only one referenced in the method body.This is an example of #100499 that I couldn't find elsewhere in the tests.