Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cached cgroup values #102971

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Remove cached cgroup values #102971

merged 2 commits into from
Jun 5, 2024

Conversation

cshung
Copy link
Member

@cshung cshung commented Jun 2, 2024

This will make RefreshMemoryLimit works when the actual cgroup value changes.

@cshung cshung self-assigned this Jun 2, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

@Maoni0
Copy link
Member

Maoni0 commented Jun 3, 2024

I don't see why there should be a behavior difference between the linux impl and window impl to begin with. and right now if we go from not having a limit to having a limit, linux and windows still behavior differently if refresh is not called. but we should address that in a separate PR as this will need to be backported to 8.0.

@cshung cshung merged commit f5a7326 into dotnet:main Jun 5, 2024
89 checks passed
@cshung cshung deleted the public/remove-cache branch June 5, 2024 14:37
cshung added a commit to cshung/runtime that referenced this pull request Jun 7, 2024
cshung added a commit that referenced this pull request Jun 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants