-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete ServicePointManager 🎉 #103456
Obsolete ServicePointManager 🎉 #103456
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,8 @@ | |
|
||
namespace System.Net | ||
{ | ||
// NOTE: While this class is not explicitly marked as obsolete, | ||
// it effectively is by virtue of WebRequest.Create being obsolete. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why haven't we explicitly marked it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe it was to reduce the noise for anyone still using it without suppressing it at the project level. |
||
public class FileWebRequest : WebRequest, ISerializable | ||
{ | ||
private readonly WebHeaderCollection _headers = new WebHeaderCollection(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
SslStream
part of this logic is currently unreachable - tracked by #19752runtime/src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpEndPointListener.cs
Lines 56 to 60 in d7ae8c6
runtime/src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpListener.Certificates.cs
Lines 20 to 24 in d7ae8c6
runtime/src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpEndPointListener.cs
Lines 115 to 119 in d7ae8c6