Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize locking duration for decommitLock #103996

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

cshung
Copy link
Member

@cshung cshung commented Jun 25, 2024

No description provided.

@cshung cshung marked this pull request as draft June 25, 2024 21:32
Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

@Maoni0
Copy link
Member

Maoni0 commented Jun 25, 2024

as discussed, this actually shouldn't be done since you'll hit a deadlock when multiple user threads call refresh.

@Maoni0
Copy link
Member

Maoni0 commented Jun 26, 2024

ahh, I thought this was for a different problem where we talked about the lock order. I see this is actually about moving the lock to be around the verification, then yes, this is the right thing to do.

src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved
@cshung cshung marked this pull request as ready for review June 27, 2024 06:04
@cshung cshung merged commit f920dac into dotnet:main Jun 27, 2024
89 checks passed
@cshung cshung deleted the public/decommit-fix branch June 27, 2024 06:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants