Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TryFormat_MatchesToString for HybridGlobalization #104026

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jun 26, 2024

Fixes #95623. I cannot reproduce locally.

This PR fixes NodeJS Windows runs, they were not triggered by extra platforms. It also removes a duplicated run of libraries on Windows with Chrome host - it was both in extra platforms and in runtime.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-System.Globalization disabled-test The test is disabled in source code against the issue labels Jun 26, 2024
@ilonatommy ilonatommy self-assigned this Jun 26, 2024
@ilonatommy ilonatommy changed the title Enable TryFormat_MatchesToString for HybridGlobalization` Enable TryFormat_MatchesToString for HybridGlobalization Jun 26, 2024
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

We are not running NodeJS on Windows on CI.

@ilonatommy ilonatommy marked this pull request as ready for review June 26, 2024 18:37
@ilonatommy ilonatommy marked this pull request as draft June 27, 2024 07:18
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy marked this pull request as ready for review June 27, 2024 09:55
@ilonatommy
Copy link
Member Author

/ba-g windows Release LibraryTests_NodeJs passed with TryFormat_MatchesToString executed. CI is timeouting, so merging without waiting for completion.

@ilonatommy ilonatommy merged commit 8909110 into dotnet:main Jun 27, 2024
85 of 107 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Globalization disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[browser] HybridGlobalization on Node, Windows throws with "non-standard" format of era
3 participants