Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert compile-native.proj to use local props #104072

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Jun 27, 2024

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 27, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@am11
Copy link
Member Author

am11 commented Jun 27, 2024

cdac should now be exactly as isolated as before. Let it do it's own thing until we figure out where the race is coming from. 😅

@am11
Copy link
Member Author

am11 commented Jun 27, 2024

@MichalStrehovsky an alternative is to merge #103375 instead. It simplifies it a bit, but I am not sure if it will fix the race condition. Only one way to find out. 😅

@MichalStrehovsky
Copy link
Member

My risk tolerance goes down with every day that we didn't have a usable product build. And we're on day 3 now.

I don't see that change changing things in terms of restore, so I'm not too optimistic it would fix things.

@am11
Copy link
Member Author

am11 commented Jun 27, 2024

np, I'll try to investigate it locally. Opened #104077.

@MichalStrehovsky
Copy link
Member

/ba-g unblocking official builds and SDK repo build flow. test runs will not find anything since this is not tested anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants