New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Resolve Android-specific active issues in System.Net.Security and System.Security.Cryptography #104352

Merged

simonrozsival merged 16 commits into dotnet:main from simonrozsival:resolve-android-net-security-active-issues

Jul 19, 2024

Member

simonrozsival commented Jul 3, 2024 •

edited

Loading

Closes #68206
Closes #100224

This PR resolves Android-specific active issues in System.Net.Security and System.Security.Cryptography

Android/java has stricter requirements on the hostnames it allows for SNI/ALPN
The Android implementation of SslStream server mode doesn't handle ALPN as expected
Some scenarios are only partially supported on Android
Some scenarios are not supported on Android
The OCSP protocol uses plaintext HTTP and our app setup didn't allow that. This requires a change in the app manifest.

simonrozsival added 7 commits

July 3, 2024 11:16


          Enable ServerAsyncAuthenticate_MismatchProtocols_Fails

050598d


          Enable subset of CertificateSelectionCallback_DelayedCertificate_OK

fd813a9


          Enable SslStream_StreamToStream_Alpn_NonMatchingProtocols_Fail and do…

4d66b6e

… not assume android backend supports ALPN


          Enable ConnectWithRevocation_WithCallback and pass full chain to Serv…

5ce38e3

…erCertificateContext


          Enable or permanently disable tests in SslStreamNetworkStreamTest

40924b2


          Adjust host name data for Android in SslStreamSniTest

650c5a7


          Fix expected outcome of TransportContext_ConnectToServerWithSsl_GetEx…

a17bdec

…pectedChannelBindings for Android

simonrozsival added the os-android label

dotnet-issue-labeler bot added the area-System.Net.Security label

This comment was marked as outdated.

Sign in to view

dotnet-policy-service bot assigned simonrozsival

This comment was marked as outdated.

Sign in to view

This was referenced Jul 3, 2024

STATUS_UNSUCCESSFUL in RsaCryptRoundtrip_OaepSHA1 #29683

Open

System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558

Open

SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts dotnet/dnceng#2496

Open

simonrozsival added 2 commits

July 3, 2024 16:07


          Fix ChainTests active issue on Android

de390eb


          Fix failing test

a355377

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This was referenced Jul 3, 2024

[browser][MT] test failure: Tests timed out. Killing driver service #103524

Open

System.Numerics.Tensors.Tests.TensorSpanTests test failure #103525

Closed

Build failure: Static graph-based restore failed with exit code .* but did not log an error. #103526

Open

Build failure: Static graph-based restore failed with exit code .* but did not log an error. dotnet/dnceng#3139

Closed

[browser] Connection refused in 127.0.0.1 #104349

Open


          TMP: Print full exception stacktrace

1be0a16

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

simonrozsival added 2 commits

July 4, 2024 14:37


          Adjust expected exception for server authentication protocol mismatch

2a94f97


          Revert "TMP: Print full exception stacktrace"

0628fca

This reverts commit 1be0a16.

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view


          Adjust the expected exceptions for arm and x86/x64

adc82c0

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This was referenced Jul 4, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

The job running on agent NetCore-Public ran longer than the maximum time #104044

Closed


          Fix assert

3feb4cc

Member Author

simonrozsival commented Jul 8, 2024

/azp run runtime-extra-platforms

azure-pipelines bot commented Jul 8, 2024

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival changed the title ~~[Android] Resolve Android-specific System.Net.Security active issues~~ [Android] Resolve Android-specific active issues in System.Net.Security and System.Security.Cryptography

simonrozsival marked this pull request as ready for review

July 8, 2024 19:14


          Merge branch 'main' into resolve-android-net-security-active-issues

522d1c8

Member Author

simonrozsival commented Jul 19, 2024

/azp run runtime-extra-platforms

azure-pipelines bot commented Jul 19, 2024

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival requested a review from wfurt

July 19, 2024 11:40

This was referenced Jul 19, 2024

ExplicitConversion_FromSingle failing due to NaN != NaN #103347

Open

'System.Net.NameResolution.Functional.Tests' Failure #105092

Closed

nativeaot\\SmokeTests\\Reflection\\Reflection\\Reflection.cmd fails with Access Violation #105136

Closed

wfurt reviewed

View reviewed changes

src/libraries/System.Net.Security/tests/FunctionalTests/ServerAsyncAuthenticateTest.cs Outdated Show resolved Hide resolved

wfurt reviewed

View reviewed changes

src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamNetworkStreamTest.cs Outdated Show resolved Hide resolved

wfurt reviewed

View reviewed changes

src/libraries/System.Net.Security/tests/FunctionalTests/TransportContextTest.cs Outdated Show resolved Hide resolved

wfurt approved these changes

View reviewed changes

Member

wfurt left a comment

I left few comments. Generally looks OK to me.


          Address review comments

6ccc908

Member Author

simonrozsival commented Jul 19, 2024

/azp run runtime-extra-platforms

azure-pipelines bot commented Jul 19, 2024

Azure Pipelines successfully started running 1 pipeline(s).

Member Author

simonrozsival commented Jul 19, 2024

The failing tests in runtime-extra-platforms are unrelated to this PR

simonrozsival merged commit 110b5f2 into dotnet:main

188 of 200 checks passed

simonrozsival deleted the resolve-android-net-security-active-issues branch

July 19, 2024 20:41

github-actions bot locked and limited conversation to collaborators

karelz added this to the 9.0.0 milestone

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.