Avoid unobserved task exceptions in Http tests #104384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Jul 3, 2024
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs
Show resolved
Hide resolved
MihaZupan
force-pushed
the
http-unobservedExceptions
branch
from
cfdabca
to
38d47dd
Compare
stephentoub
reviewed
Jul 5, 2024
| @@ -496,6 +496,7 @@ private async Task ProcessIncomingFramesAsync() | |||
| catch (HttpProtocolException e) | |||
| { | |||
| InitialSettingsReceived.TrySetException(e); | |||
| LogExceptions(InitialSettingsReceived.Task); | |||
There was a problem hiding this comment.
InitialSettingsReceived isn't guaranteed to be await'd/consumed elsewhere?
There was a problem hiding this comment.
No, we'll only look at it if/when we're sending an H2 WebSocket request.
stephentoub
approved these changes
Jul 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #80111 (comment) by removing most unobserved non-Quic exceptions from our HTTP tests.
The only product change is the 1 added
LogExceptionsinHttp2Connection.cs.