Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonSchemaExporterContext.BaseTypeInfo #104550

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Add JsonSchemaExporterContext.BaseTypeInfo #104550

merged 1 commit into from
Jul 9, 2024

Conversation

eiriktsarpalis
Copy link
Member

Fix #104046. NB this is pending API approval.

cc @captainsafia

@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Jul 8, 2024
@eiriktsarpalis eiriktsarpalis self-assigned this Jul 8, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member

Add JsonSchemaExporterContext.ParentTypeInfo

BaseTypeInfo?

@eiriktsarpalis eiriktsarpalis changed the title Add JsonSchemaExporterContext.ParentTypeInfo Add JsonSchemaExporterContext.BaseTypeInfo Jul 8, 2024
@eiriktsarpalis
Copy link
Member Author

Approved by API review.

@eiriktsarpalis eiriktsarpalis merged commit 7f5ce1e into dotnet:main Jul 9, 2024
83 checks passed
@eiriktsarpalis eiriktsarpalis deleted the jsonschema-parentpoly branch July 9, 2024 19:05
matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@matouskozak
Revert "Add JsonSchemaExporterContext.ParentTypeInfo (dotnet#104550)"
efd3f9d 
This reverts commit 7f5ce1e.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Expose polymorphic base type in JsonSchemaExporterContext
2 participants
@eiriktsarpalis @stephentoub