Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasi] back to WASI_SDK_PATH and detection improvement #104729

Merged
merged 3 commits into from
Jul 11, 2024
Merged

[wasi] back to WASI_SDK_PATH and detection improvement #104729

merged 3 commits into from
Jul 11, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 11, 2024 •
edited
Loading

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Jul 11, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jul 11, 2024
@pavelsavara pavelsavara self-assigned this Jul 11, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara marked this pull request as ready for review July 11, 2024 13:48
This was referenced Jul 11, 2024
Merged
Open
@pavelsavara
Copy link
Member Author

/ba-g known issue #104737 and timeouts. All relevant WASI tests passed

@pavelsavara pavelsavara merged commit 8b3bde3 into dotnet:main Jul 11, 2024
133 of 160 checks passed
@pavelsavara pavelsavara deleted the WASI_SDK_PATH_again branch July 11, 2024 16:35
This was referenced Jul 11, 2024
Open
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@maraf maraf maraf approved these changes

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @lewing @maraf