Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libicu74 as a known ICU version #104754

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add libicu74 as a known ICU version #104754

merged 1 commit into from
Jul 17, 2024

Conversation

jkoritzinsky
Copy link
Member

Ubuntu 24.04 ships ICU v74 as the libicu74 package, so we need to add it as a known version.

Contributes to dotnet/sdk#40506

This does not affect source-build. Canonical defines their own deb packages and they do not use the runtime-deps package.

Ubuntu 24.04 ships ICU v74 as the libicu74 package, so we need to add it as a known version.

Contributes to dotnet/sdk#40506

This does not affect source-build. Canonical defines their own deb packages and they do not use the runtime-deps package.
@jkoritzinsky
Copy link
Member Author

/backport to release/8.0-staging

@jkoritzinsky
Copy link
Member Author

/backport to release/6.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9898509112

@jkoritzinsky jkoritzinsky added this to the 9.0.0 milestone Jul 11, 2024
Copy link
Contributor

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/9898510461

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hopping on this so quickly!

@jkoritzinsky jkoritzinsky added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 11, 2024
@jkoritzinsky
Copy link
Member Author

Marking as no-merge until questions in dotnet/sdk#40506 are resolved.

@jkoritzinsky
Copy link
Member Author

I spoke offline with Rich. We'll merge this in now and make an issue for next steps to better guide users to the best experience.

@jkoritzinsky jkoritzinsky removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 17, 2024
@jkoritzinsky jkoritzinsky merged commit 27776e2 into main Jul 17, 2024
70 checks passed
@jkoritzinsky jkoritzinsky deleted the libicu74 branch July 17, 2024 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Setup os-linux Linux OS (any supported distro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants