#ifdef out of the DACCESS_BUILD the GetMethodDescForSlot api #104989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Discovered a method `GetIntroducingMethodDesc` which isn't used by anything
|
Tagging subscribers to this area: @mangod9 |
lambdageek
approved these changes
Jul 16, 2024
|
@mikem8361 Lets get your change in, and then I'll merge mine. Yours is a bit further along in testing, and fixes the actual issue which is breaking things. Mine is more of a nice-to-have. |
This was referenced Jul 16, 2024
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetIntroducingMethodDescwhich isn't used by anythingThis is work on top of #104939 which makes that bug impossible to add back to the product accidentally. Unfortunately, I couldn't remove
GetRestoredSlotfrom the DACCESS build, as it relies on doing vtable discovery during stepping. Fortunately this should be safe, but it's unfortunate we need to have a function which behaves differently in DAC vs non-DAC builds.