Do not allow a non-keyed service to be injected to a keyed parameter #105839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveharter
added
the
breaking-change
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
steveharter
commented
Aug 1, 2024
| } | ||
|
|
||
| [Fact] | ||
| public void ResolveKeyedServiceWithKeyedParameter_MissingRegistrationButWithUnkeyedService() |
There was a problem hiding this comment.
The above tests were not failing before this PR, but this test and the other new test in "ServiceProviderContainerTests.cs" were.
buyaa-n
reviewed
Aug 3, 2024
...ies/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 7, 2024
ericstj
approved these changes
Aug 7, 2024
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/10525564051 |
Merged
4 tasks
|
Breaking change doc at: dotnet/docs#42313 |
steveharter
removed
the
needs-breaking-change-doc-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102204