Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Remove --user from pip installs #106055

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Aug 6, 2024

Remove --user from pip installs now that venv activation is working properly. This fixes the following error in the windows crossgen runs: ERROR: Can not perform a '--user' install. User site-packages are not visible in this virtualenv.

Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2510047&view=results

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@LoopedBard3
Copy link
Member Author

Test run shows successful windows crossgen run, merging.

@LoopedBard3 LoopedBard3 merged commit 1716c4b into dotnet:main Aug 7, 2024
16 of 18 checks passed
@LoopedBard3 LoopedBard3 deleted the PerfFixScenarioPipInstall branch August 7, 2024 06:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants