Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packaging.targets #106327

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Update packaging.targets #106327

merged 1 commit into from
Aug 15, 2024

Conversation

ViktorHofer
Copy link
Member

Fixes:

C:\git\runtime3\eng\packaging.targets(211,5): error NETPKG0001: Project reference '' is a reference to a framework asse
mbly and is not required in net9.0 (NetCoreAppCurrent). [C:\git\runtime3\src\libraries\System.Text.Json\src\System.Text .Json.csproj::TargetFramework=net9.0]

@ViktorHofer
Update packaging.targets
53e1b23 
Fixes:

> C:\git\runtime3\eng\packaging.targets(211,5): error NETPKG0001: Project reference '' is a reference to a framework asse
mbly and is not required in net9.0 (NetCoreAppCurrent). [C:\git\runtime3\src\libraries\System.Text.Json\src\System.Text
.Json.csproj::TargetFramework=net9.0]
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Aug 13, 2024
Open
@ViktorHofer
Copy link
Member Author

@ericstj PTAL

ericstj
ericstj approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @ViktorHofer

@ericstj ericstj merged commit f00fc03 into main Aug 15, 2024
147 of 149 checks passed
@ericstj
Copy link
Member

ericstj commented Aug 15, 2024

/backport to release/9.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10408589651

@github-actions github-actions bot mentioned this pull request Aug 15, 2024
Merged
1 task
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-3 branch August 15, 2024 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj ericstj approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorHofer @ericstj