JIT: Give Compiler a proper constructor
#107098
Conversation
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS With this change No diffs, some minor TP diffs (the somewhat large MinOpts ones are in collections with almost no MinOpts contexts). |
src/coreclr/jit/compiler.cpp
Outdated
| #endif // DEBUG | ||
|
|
||
| #if defined(FEATURE_EH_WINDOWS_X86) | ||
| // Cache Native AOT ABI check. This must happen *after* eeInfoInitialized is initialized, above. |
There was a problem hiding this comment.
Maybe reword this comment? eeInfoInitialized is now initialized inline (which I assume happens "before" the constructor body runs).
There was a problem hiding this comment.
Deleted the comment (indeed, all the inline initialization happens before the body here runs, so we shouldn't have concerns like this anymore)
- Add a proper constructor for `Compiler` and call it via placement new from `jitNativeCode`. - Remove `compInit`, `fgInit`, `impInit`, `lvaInit` and `optInit`. Move all their initialization into the constructor or, when possible, initialize the field directly with its declaration.
Compilerand call it via placement new fromjitNativeCode.compInit,fgInit,impInit,lvaInitandoptInit. Move all their initialization into the constructor or, when possible, initialize the field directly with its declaration.