Do not over-align code when JitAlignLoops=0 is set #107340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
3 tasks
kunalspathak
reviewed
Sep 5, 2024
| if (emitComp->opts.OptimizationEnabled() && | ||
| (!emitComp->opts.jitFlags->IsSet(JitFlags::JIT_FLAG_PREJIT) || comp->IsTargetAbi(CORINFO_NATIVEAOT_ABI)) && | ||
| (emitTotalHotCodeSize > 16) && emitComp->fgHasLoops) | ||
| if (codeGen->ShouldAlignLoops() && (emitTotalHotCodeSize > 16) && emitComp->fgHasLoops) |
There was a problem hiding this comment.
Should we also set JitAlignLoops to false if we are optimizing for size and hence, here we will also adjust the method alignment to 8 bytes instead of 32 bytes?
There was a problem hiding this comment.
I’d say yes. I wanted to unblock my testing first which is why I submitted this separately.
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the condition for alignment of methods with loop. The check for optimizations, R2R and NativeAOT already guards the
SetAlignLoopscode path, so there's no need to repeat it. Additionally, explicitly disabling loop alignment withJitAlignLoops=0should disable the extra method alignment.