Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASI] HTTP trailers #107795

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WASI] HTTP trailers #107795

wants to merge 4 commits into from
+126 −119

Conversation

pavelsavara
Copy link
Member

  • HTTP trailers
  • bump wit-bindgen

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Net.Http os-wasi Related to WASI variant of arch-wasm labels Sep 13, 2024
@pavelsavara pavelsavara added this to the 10.0.0 milestone Sep 13, 2024
@pavelsavara pavelsavara self-assigned this Sep 13, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member Author

cc @dicej @jsturtevant

@ilonatommy ilonatommy mentioned this pull request Sep 13, 2024
Merged
This was referenced Sep 13, 2024
Open
Open
Open
jsturtevant
jsturtevant reviewed Sep 13, 2024
View reviewed changes
Copy link

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelsavara pavelsavara marked this pull request as ready for review September 13, 2024 17:21
pavelsavara
pavelsavara commented Sep 16, 2024
View reviewed changes
src/mono/sample/wasi/http-p2/Program.cs
using (HttpClient httpClient = new HttpClient())
{
httpClient.DefaultRequestVersion = HttpVersion.Version20;
httpClient.DefaultRequestHeaders.Add("TE", "trailers");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understandably the line with HttpVersion.Version20 doesn't do anything right now.

But I'm getting ITypes.HeaderError.FORBIDDEN from wasmtime v24 for setting TE header. Am I doing it wrong ?
I remeber there was some discussion about it, but can't find it now.

@dicej

@build-analysis build-analysis bot mentioned this pull request Sep 16, 2024
Open
@pavelsavara pavelsavara added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 17, 2024
@pavelsavara
Copy link
Member Author

This is blocked until wasmtime allows sending TE header

@pavelsavara pavelsavara marked this pull request as draft September 17, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@wfurt wfurt wfurt left review comments

@dicej dicej dicej approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Net.Http NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelsavara @jsturtevant @dicej @wfurt