More doc updates for source-of-truth assemblies #107810
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
changed the title
src/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/InstrumentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeasurementHandlers.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeasurementHandlers.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeasurementHandlers.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeasurementHandlers.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.FileProviders.Abstractions/src/IFileInfo.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.FileProviders.Abstractions/src/IFileInfo.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PollingFileChangeToken.cs
Outdated
Show resolved
Hide resolved
carlossanlop
added
area-Extensions-FileSystem
area-Meta
documentation
|
Tagging subscribers to this area: @dotnet/area-meta |
1 similar comment
|
Tagging subscribers to this area: @dotnet/area-meta |
carlossanlop
approved these changes
Sep 13, 2024
src/libraries/Microsoft.Extensions.Hosting/src/ConsoleLifetimeOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Logging.Abstractions/src/LogEntry.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Logging.Abstractions/src/LoggerExtensions.cs
Show resolved
Hide resolved
| /// </summary> | ||
| public string? SourceName { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Name of the machine having the event log. If <c>null</c> or not specified, local machine is the default. | ||
| /// Gets or sets the name of the machine with the event log. If <see langword="null" /> or not specified, local machine is the default. |
There was a problem hiding this comment.
For consistency with the others:
Suggested change
| /// Gets or sets the name of the machine with the event log. If <see langword="null" /> or not specified, local machine is the default. | |
| /// Gets or sets the name of the machine with the event log. If <see langword="null" /> or not specified, "local machine" is the default. |
@dotnet/area-extensions-logging does this default value begin in lowercase?
src/libraries/Microsoft.Extensions.Primitives/src/StringSegment.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Primitives/src/StringTokenizer.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Primitives/src/StringTokenizer.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Primitives/src/StringValues.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
|
It would be nice to backport this to 9.0. Today's the snap for the RC2 branch but we still have time tomorrow before we start the builds. Would you mind looking at the feedback when you get a chance @gewarren? |
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
gewarren
commented
Sep 17, 2024
src/libraries/Microsoft.Extensions.Primitives/src/StringTokenizer.cs
Outdated
Show resolved
Hide resolved
|
@carlossanlop There seem to be a lot of errors. Is this okay to merge? |
| @@ -426,8 +426,8 @@ private void GenLogMethod(LoggerMethod lm, string nestedIndentation) | |||
| {nestedIndentation}{enabledCheckIndentation}{level}, | |||
| {nestedIndentation}{enabledCheckIndentation}new global::Microsoft.Extensions.Logging.EventId({lm.EventId}, {eventName}), | |||
| {nestedIndentation}{enabledCheckIndentation}"); | |||
| GenHolder(lm); | |||
| _builder.Append($@", | |||
| GenHolder(lm); | |||
There was a problem hiding this comment.
@dotnet/area-extensions-logging do you know if the CI failures might be related to changes to the gen files in this PR? Some of the failures say that lines do not match, but I don't know enough to determine if we need to avoid changes in such files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/dotnet-api-docs#9989.