[WASI] ownsPollable parameter to RegisterWasiPollable, downgrade dependencies #107978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pavelsavara
commented
Sep 18, 2024
pavelsavara
commented
- add ownsPollable to RegisterWasiPollable
- revert WASI APIs to version 0.2.0 to match libc until fix lands in SDK we use
- add ownsPollable to RegisterWasiPollable
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
commented
Sep 18, 2024
| @@ -178,7 +180,9 @@ public void ResolveAndDispose() | |||
|
|
|||
| // no need to unregister the holder from s_pollables, when this is called | |||
| isDisposed = true; | |||
| pollable.Dispose(); | |||
| if (ownsPollable){ | |||
There was a problem hiding this comment.
This is the interesting part.
Related: The new wit-bindgen doesn't generate finalizers anymore. That's good because resources can't be disposed in random order.
Related: when we take pollable handles from libc internals, they are still owned by libc and we should not dispose them here. That's why the new parameter, which will be used in sockets PR
And to be able to use pollable handles from libc we have to match the component interface version (until tooling is fixed)
akoeplinger
approved these changes
Sep 18, 2024
3 tasks
maraf
approved these changes
Sep 18, 2024
|
/ba-g CI timeout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.