Removed test scripts platform conditions #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… regardless of platform.
ivdiazsa
added
test-enhancement
trylek
approved these changes
Nov 25, 2019
MichalStrehovsky
pushed a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Nov 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under
coreclr/tests/src/CLRTest.Execute.targets, there were a couple conditionals that checked whether the current platform was any Windows flavor. If so, then a.cmdwrapper script was generated for the tests. Otherwise, a.shone was created instead.As the first step in the upcoming test build optimizations and include/exclude filters, we require that both wrappers are generated, so this commit removes the conditionals to always have both wrappers, regardless of platform or test restrictions.