Add link to shared portion of CoreLib to .gitignore #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the coreclr repo, one could simply findstr in the System.Private.CoreLib directory to find stuff. Since in the runtime repo the shared portion of the CoreLib moved to src/libraries/, but private portion lives in src/coreclr, the files are split. We can work around it locally by making a symbolic link. That way runtime devs that just grep/findstr stuff don't have to suffer entering the src/libraries directory where tab completion doesn't work because there's 180 directories prefixed by `System.`.
jkotas
approved these changes
Jan 11, 2020
jkotas
reviewed
Jan 11, 2020
| @@ -338,3 +338,10 @@ sandbox | |||
|
|
|||
| #IL linker for testing | |||
| linker | |||
|
|
|||
| # Symbolic link for the shared portion of CoreLib | |||
| # On Windows, make your own by running these commands from the repo root: | |||
There was a problem hiding this comment.
List the Unix commands as well for parity?
|
Is this worth mentioning as a ProTip in a doc? |
Do you have a suggestion for which doc to add it to? I looked through the /docs folder but couldn't find anything obvious. My plan was to cc folks who are likely to often work on the runtime/corelib boundary where they need to find references to something across the VM/corelib boundary (maybe @dotnet/crossgen-contrib). I assume people who write CoreLib code would use the VS solution file. |
|
ok |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the coreclr repo, one could simply findstr in the System.Private.CoreLib directory to find stuff.
Since in the runtime repo the shared portion of the CoreLib moved to src/libraries/, but private portion lives in src/coreclr, the files are split. We can work around it locally by making a symbolic link.
That way runtime devs that just grep/findstr stuff don't have to suffer entering the src/libraries directory where tab completion doesn't work because there's 180 directories prefixed by
System..