Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable zip unicode tests on OSX #1728

Merged
merged 2 commits into from
Jan 21, 2020
Merged

enable zip unicode tests on OSX #1728

merged 2 commits into from
Jan 21, 2020

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jan 14, 2020

I did test ruin on my OSX and it seems to work fine.

fixes #1551

@wfurt wfurt added area-System.IO disabled-test The test is disabled in source code against the issue os-mac-os-x macOS aka OSX labels Jan 14, 2020
@wfurt wfurt self-assigned this Jan 14, 2020
@safern
Copy link
Member

safern commented Jan 14, 2020

All configurations leg was just fixed in: #1729

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, @wfurt. I clicked on Re-Run for the failed CI runs, but maybe a rebase is required?

@wfurt wfurt closed this Jan 16, 2020
@wfurt wfurt reopened this Jan 16, 2020
@wfurt
Copy link
Member Author

wfurt commented Jan 16, 2020

/azp list

@wfurt
Copy link
Member Author

wfurt commented Jan 16, 2020

/azp run runtime-libraries

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@safern
Copy link
Member

safern commented Jan 16, 2020

@wfurt runtime-installer pipeline is deprecated, now everything is part of the "runtime" pipeline. We're in the process of updating docs... if you want to remove the red badges, you can amend your commit (to change the hash) and push, or just ignore the failures in runtime-libraries if "runtime" is green, we test the same things now in "runtime".

The failure you're seeing on Installer Build and Test Windows_NT_x86 Release is a known issue and you can ignore, so basically this PR is good to merge.

@wfurt
Copy link
Member Author

wfurt commented Jan 16, 2020

I really wanted to run ' (Libraries Build OSX x64 Debug)' Since it was canceled I could not use restart option.

@safern
Copy link
Member

safern commented Jan 16, 2020

I really wanted to run ' (Libraries Build OSX x64 Debug)' Since it was canceled I could not use restart option.

Right, but the one that was cancelled was the one under the "runtime-libraries" pipeline. If you look at the "runtime" pipeline it also has a step to Build OSX x64 Debug and run tests:

image

image

That's what I meant with now these steps are part of the "runtime" pipeline as "runtime-libraries" no longer exist. The reason why it is showed, is because GH stores the badge information in relation to the HEAD commit hash, since you only closed/re-open the PR and the pipelines changed while your PR was open, it will see that the hash existed and will not remove badges for builds that no longer exist.

@wfurt wfurt merged commit 644bdd9 into dotnet:master Jan 21, 2020
@wfurt wfurt deleted the enable_1551 branch January 21, 2020 20:29
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO disabled-test The test is disabled in source code against the issue os-mac-os-x macOS aka OSX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate rel OSX ZipFile failures
3 participants