Enable Mono build in CI #1934

akoeplinger · 2020-01-20T10:31:59Z

Fixes #1932

This reverts commit 8c1e766.

…to enable-mono-ci

This reverts commit 6b83c47. This reverts commit df16fe3.

# Conflicts: # eng/pipelines/libraries/base-job.yml

Fails due to #1933

safern · 2020-01-22T18:26:57Z

eng/pipelines/common/platform-matrix.yml

+        # alpine coreclr cmake errors on newer builds
+        ${{ if eq(parameters.runtimeFlavor, 'mono') }}:
+          image: alpine-3.9-WithNode-0fc54a3-20200121145958
+        ${{ if ne(parameters.runtimeFlavor, 'mono') }}:


Can we open an issue for this and investigate? We should try to be consistent with the docker images we build with.

Also, instead of using != mono I would change this to == coreclr so that it is easier to read.

Suggested change

${{ if ne(parameters.runtimeFlavor, 'mono') }}:

${{ if eq(parameters.runtimeFlavor, 'coreclr') }}:

Yes I'll file an issue for that as it's highly concerning. Just hadn't had time yet.

safern · 2020-01-22T18:28:14Z

eng/pipelines/common/xplat-setup.yml

@@ -50,6 +50,13 @@ jobs:
        - name: ROOTFS_DIR
          value: ${{ parameters.jobParameters.crossrootfsDir }}

+      - ${{ if ne(parameters.jobParameters.runtimeFlavor, '') }}:


runtimeFlavor should always be passed down as a jobParameter since platform-matrix is passing it down always, so no need to have this empty check any more.

safern · 2020-01-22T18:30:10Z

eng/pipelines/libraries/build-job.yml

@@ -80,7 +81,7 @@ jobs:

        - ${{ if eq(parameters.osGroup, 'OSX') }}:
          - script: |
-              brew install pkgconfig icu4c openssl
+              brew install pkgconfig icu4c openssl autoconf automake libtool pkg-config python3


why do we need these? This is building libraries, not mono.

cc @akoeplinger

We probably don't. I was just adding dependencies where it seemed fit and didn't notice this is only used for libraries build.

safern · 2020-01-22T18:33:25Z

eng/pipelines/mono/templates/build-job.yml

+- template: xplat-pipeline-job.yml
+  parameters:
+    buildConfig: ${{ parameters.buildConfig }}
+    _BuildConfig: ${{ parameters.buildConfig }}


This parameter is not used in mono/xplat-pipeline-job.yml, not even defined as a parameter in the template.

safern · 2020-01-22T18:34:03Z

eng/pipelines/mono/templates/build-job.yml

+    osSubgroup: ${{ parameters.osSubgroup }}
+    helixType: 'build/product/'
+    enableMicrobuild: true
+    stagedBuild: ${{ parameters.stagedBuild }}


stagedBuild is not necessary at all, right?

safern · 2020-01-22T18:35:00Z

eng/pipelines/mono/templates/xplat-job.yml

+    container: ${{ parameters.container }}
+    condition: ${{ parameters.condition }}
+    dependsOn:
+      - ${{ if ne(parameters.stagedBuild, true) }}:


I don't think this will ever be true.

Right, this is a copy from coreclr. I assumed it will always be true but didn't change it as this would need to be cleaned-up in coreclr as well and I wanted to minimize risk.

safern · 2020-01-22T18:35:44Z

eng/pipelines/mono/templates/xplat-job.yml

@@ -0,0 +1,111 @@
+parameters:


This seems very similar to coreclr's xplat-job template, can we share them? Maybe move coreclr's to common.

See answer below.

safern · 2020-01-22T18:36:14Z

eng/pipelines/mono/templates/xplat-pipeline-job.yml

@@ -0,0 +1,67 @@
+parameters:


Instead of introducing another template, can we use coreclr's and move it to common?

I tried to share them but there were too many differences in paths which weren't easy to fix. We should file an issue to consolidate runtime (coreclr & mono) infrastructure files where possible (not just yml).

Sounds good. Let's please open that issue as it seems overkill to have this duplicate templates (maintaining multiple yml files is painful).

safern · 2020-01-22T18:36:55Z

eng/pipelines/runtime.yml

+      - eng/pipelines/libraries/*
+    - subset: mono
+      include:
+      - src/libraries/System.Private.CoreLib/*


Does mono depend on the native libraries? src/libraries/Native?

for building mono? I don't think so. cc @akoeplinger

The Mono build doesn't depend on src/libraries/Native.

but what about the tests?

We'll enable Mono runtime tests at a later point so that's not an issue for now.

safern · 2020-01-22T18:39:23Z

src/mono/Directory.Build.props

+
+  <!-- Set default Configuration and Platform -->
+  <PropertyGroup>
+    <OSGroup Condition="'$(OSGroup)' == '' and '$([MSBuild]::IsOSPlatform(Windows))' == 'true'">Windows_NT</OSGroup>


Can this instead be shared by libraries, coreclr and mono?

not until we have merged @Anipik's configuration system PR.

safern · 2020-01-22T18:39:53Z

src/mono/Directory.Build.props

+
+  <PropertyGroup>
+    <LangVersion>8.0</LangVersion>
+    <UseSharedCompilation>true</UseSharedCompilation>


Aren't this properties defined in the root, Directory.Build.props? Should we instead put them there?

I already removed bunch of duplicate properties, I don't plan to remove more as part of this PR. I have an open PR for the managed side of coreclr in which I will include changes for mono as well.

safern · 2020-01-22T18:46:21Z

eng/pipelines/runtime.yml

+      testScope: innerloop
+      liveRuntimeBuildConfig: release
+      dependsOnTestBuildConfiguration: ${{ variables.debugOnPrReleaseOnRolling }}
+      dependsOnTestArchitecture: x64


Should this be conditioned to when mono or libraries is changed?

I don't think we want to run this tests when only coreclr is touched or when only installer is touched. That said, I believe the build of mono release should also have the same condition as this step.

akoeplinger · 2020-01-22T20:19:34Z

@safern thanks for the review, I filed an issue to address the review feedback in a follow-up PR as we need to get this PR in: #2026

* Address follow-up feedback from #1934 * Remove whitespaces

Follow-up to dotnet#1934 Also disables one test that seems to be flaky on Mono.

Follow-up to #1934 Also disables one test that seems to be flaky on Mono.

Enable Mono in default build

dda0e24

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Jan 20, 2020

akoeplinger and others added 7 commits January 20, 2020 12:16

Install Mono build dependencies

9dd624a

Integrate Mono into the build system

b38c606

Fix yml syntax

b71b56d

Fix yml #2

3fc55c6

Try another syntax

8c1e766

Revert "Try another syntax"

fc15f62

This reverts commit 8c1e766.

RuntimeFlavor and yml

516c74e

akoeplinger marked this pull request as ready for review January 21, 2020 20:51

akoeplinger and others added 20 commits January 21, 2020 21:52

Merge branch 'master' into enable-mono-ci

b299e14

Update build container images

20eca7c

Merge branch 'enable-mono-ci' of https://github.com/dotnet/runtime in…

1cda2e3

…to enable-mono-ci

Fix yml

4e7474e

Add libraries release test run on mono

d3622c4

Installer yml fixes

876a802

Fix yml

579cac8

Move yml block

d38acee

Yml fixes

87dc59e

Yml fix

7c49749

yml fix juhu

3e02bac

Yml fixes

00d3770

yml fixes

d05dd74

yml again

015f2dc

Build release only

6b83c47

Fix yml

df16fe3

Revert "Build release only"

ec4268e

This reverts commit 6b83c47. This reverts commit df16fe3.

Merge remote-tracking branch 'upstream/master' into enable-mono-ci

79a41ad

# Conflicts: # eng/pipelines/libraries/base-job.yml

Fix script args

4451143

Remove corecrl specific args

23437a8

akoeplinger and others added 6 commits January 22, 2020 15:28

Disable Windows runs

90788fc

Fails due to #1933

Disable more tests

cfd3e79

Disable mono windows test runs

73bae92

Fix doc about RuntimeFlavor

b6df298

Disable more tests

480e7cb

Fix Windows build

060c3d8

safern reviewed Jan 22, 2020

View reviewed changes

akoeplinger mentioned this pull request Jan 22, 2020

Address feedback from Mono CI PR #2026

Closed

akoeplinger merged commit 6eb3edf into master Jan 22, 2020

akoeplinger deleted the enable-mono-ci branch January 22, 2020 20:20

dagood mentioned this pull request Jan 23, 2020

Official build break: CoreCLR asset path missing '/' in installer subset #2053

Closed

ViktorHofer added a commit that referenced this pull request Jan 23, 2020

Address follow-up feedback from #1934 (#2028)

03f8ed5

* Address follow-up feedback from #1934 * Remove whitespaces

jaredpar mentioned this pull request Jan 23, 2020

Local live builds not picking up runtime config #2093

Merged

akoeplinger added a commit to akoeplinger/runtime that referenced this pull request Jan 23, 2020

Fix pipeline trigger for running libraries tests against Mono

037390e

Follow-up to dotnet#1934 Also disables one test that seems to be flaky on Mono.

akoeplinger mentioned this pull request Jan 23, 2020

Fix pipeline trigger for running libraries tests against Mono #2097

Merged

akoeplinger added a commit that referenced this pull request Jan 24, 2020

Fix pipeline trigger for running libraries tests against Mono (#2097)

d28b9ee

Follow-up to #1934 Also disables one test that seems to be flaky on Mono.

jaredpar mentioned this pull request Jan 31, 2020

Broke ability to use RuntimeFlavor in local builds #23800

Closed

ghost locked as resolved and limited conversation to collaborators Dec 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Mono build in CI #1934

Enable Mono build in CI #1934

akoeplinger commented Jan 20, 2020 •

edited by ViktorHofer

Loading

safern Jan 22, 2020

ViktorHofer Jan 22, 2020

safern Jan 22, 2020

safern Jan 22, 2020

ViktorHofer Jan 22, 2020

akoeplinger Jan 22, 2020

safern Jan 22, 2020

safern Jan 22, 2020

safern Jan 22, 2020 •

edited

Loading

ViktorHofer Jan 22, 2020

safern Jan 22, 2020

ViktorHofer Jan 22, 2020

ViktorHofer Jan 22, 2020

safern Jan 22, 2020

ViktorHofer Jan 22, 2020 •

edited

Loading

safern Jan 22, 2020

ViktorHofer Jan 22, 2020

safern Jan 22, 2020

ViktorHofer Jan 22, 2020

akoeplinger Jan 22, 2020

safern Jan 22, 2020

akoeplinger Jan 22, 2020

safern Jan 22, 2020

ViktorHofer Jan 22, 2020

safern Jan 22, 2020

ViktorHofer Jan 22, 2020

safern Jan 22, 2020

safern Jan 22, 2020

akoeplinger commented Jan 22, 2020

	${{ if ne(parameters.runtimeFlavor, 'mono') }}:
	${{ if eq(parameters.runtimeFlavor, 'coreclr') }}:

Enable Mono build in CI #1934

Enable Mono build in CI #1934

Conversation

akoeplinger commented Jan 20, 2020 • edited by ViktorHofer Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

safern Jan 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ViktorHofer Jan 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akoeplinger commented Jan 22, 2020

akoeplinger commented Jan 20, 2020 •

edited by ViktorHofer

Loading

safern Jan 22, 2020 •

edited

Loading

ViktorHofer Jan 22, 2020 •

edited

Loading