Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup regex diagnostic output #1947

Merged
merged 10 commits into from
Jan 21, 2020
Merged

Cleanup regex diagnostic output #1947

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7afa235
Include actual pattern in diagnostic output
danmoseley Jan 20, 2020
fee8667
Fix char category name in diagnostic output
danmoseley Jan 20, 2020
98a5e52
Tighten Boyer Moore debug output
danmoseley Jan 20, 2020
83bd5e3
Clean up diagnostic output from RegexCode and RegexNode
danmoseley Jan 20, 2020
8354920
Apply suggestions from code review
danmoseley Jan 21, 2020
bd4ae63
more
danmoseley Jan 21, 2020
7a5511f
display options and timeout
danmoseley Jan 21, 2020
92ad114
Some random nits
danmoseley Jan 21, 2020
ebcd1c3
Update src/libraries/System.Text.RegularExpressions/src/System/Text/R…
danmoseley Jan 21, 2020
a17ff50
Github typo
danmoseley Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tighten Boyer Moore debug output
  • Loading branch information
@danmoseley
danmoseley committed Jan 21, 2020
commit 98a5e524c48d20f95b7f3fe93f331022a2fa59df
6 changes: 4 additions & 2 deletions ...ries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexBoyerMoore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,16 +357,18 @@ public string Dump(string indent)

if (NegativeASCII != null)
{
sb.Append(indent + "Negative table\n");
sb.Append(indent + "Negative table: ");
for (int i = 0; i < NegativeASCII.Length; i++)
{
if (NegativeASCII[i] != Pattern.Length)
{
sb.Append(indent + " " + Regex.Escape(Convert.ToString((char)i, CultureInfo.InvariantCulture)) + " " + NegativeASCII[i].ToString(CultureInfo.InvariantCulture) + "\n");
sb.Append(" {" + Regex.Escape(Convert.ToString((char)i, CultureInfo.InvariantCulture)) + " " + NegativeASCII[i].ToString(CultureInfo.InvariantCulture) + "}");
danmoseley marked this conversation as resolved.
Show resolved Hide resolved
}
}
}

sb.Append("\n");
danmoseley marked this conversation as resolved.
Show resolved Hide resolved

return sb.ToString();
}
#endif
Expand Down