-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example profiler that does stack sampling with ICorProfilerInfo10::SuspendRuntime #32988
Conversation
Why are we doing this in the dotnet/runtime repo? It seems the correct place for sample code is in the dotnet/samples repo. |
I view that as more of C# samples developers. I don't mind if code lives over there, but it doesn't seem like it belongs there any more than here. This is a repeated problem the profiler runs in to. It's pretty different from anything else we do so there's no clear home for a lot of documentation/samples/etc. |
Ping @noahfalk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the jit event tracking
docs/design/coreclr/profiling/sample-profilers/stacksampling/src/CorProfiler.cpp
Show resolved
Hide resolved
C# samples have advanced C++ samples too, e.g.: https://github.com/dotnet/samples/tree/master/core/hosting I agree with @sdmaclea that this would be better to have in dotnet/samples.
The profiler APIs docs have a home in the docs, e.g. : Have you talked about this to the docs team? |
I don't have super strong feelings about it, so I can move it. I mainly just want it to be somewhere so I can point people to it when they ask. I didn't see native hosting samples.
We have had some preliminary discussions about updating the API docs you referred above to reflect the growing differences in core and desktop. The documentation I was talking about was the long form, blog post style docs in the docs/design/coreclr/profiling path. I haven't had discussions with them about this style of documentation. |
This type of documentation is there as well, e.g. https://docs.microsoft.com/en-us/dotnet/framework/unmanaged-api/profiling/profiling-overview |
…erInfo10::SuspendRuntime (dotnet#32988)" This reverts commit 7a362a0.
No description provided.