Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example profiler that does stack sampling with ICorProfilerInfo10::SuspendRuntime #32988

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

davmason
Copy link
Member

No description provided.

@davmason davmason requested review from noahfalk and a team February 28, 2020 21:29
@davmason davmason self-assigned this Feb 28, 2020
@sdmaclea
Copy link
Contributor

Why are we doing this in the dotnet/runtime repo? It seems the correct place for sample code is in the dotnet/samples repo.

@davmason
Copy link
Member Author

Why are we doing this in the dotnet/runtime repo? It seems the correct place for sample code is in the dotnet/samples repo.

I view that as more of C# samples developers. I don't mind if code lives over there, but it doesn't seem like it belongs there any more than here.

This is a repeated problem the profiler runs in to. It's pretty different from anything else we do so there's no clear home for a lot of documentation/samples/etc.

@davmason
Copy link
Member Author

Ping @noahfalk

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the jit event tracking

@davmason davmason merged commit 7a362a0 into dotnet:master Mar 16, 2020
@jkotas
Copy link
Member

jkotas commented Mar 16, 2020

I view that as more of C# samples developers.

C# samples have advanced C++ samples too, e.g.: https://github.com/dotnet/samples/tree/master/core/hosting

I agree with @sdmaclea that this would be better to have in dotnet/samples.

It's pretty different from anything else we do so there's no clear home for a lot of documentation/samples/etc

The profiler APIs docs have a home in the docs, e.g. :
https://github.com/dotnet/docs/blob/master/docs/framework/unmanaged-api/profiling/profiling-interfaces.md (https://docs.microsoft.com/en-us/dotnet/framework/unmanaged-api/profiling/icorprofilerinfo-interface is rendeded view of this content.)

Have you talked about this to the docs team?

@davmason
Copy link
Member Author

I agree with @sdmaclea that this would be better to have in dotnet/samples.

I don't have super strong feelings about it, so I can move it. I mainly just want it to be somewhere so I can point people to it when they ask. I didn't see native hosting samples.

Have you talked about this to the docs team?

We have had some preliminary discussions about updating the API docs you referred above to reflect the growing differences in core and desktop. The documentation I was talking about was the long form, blog post style docs in the docs/design/coreclr/profiling path. I haven't had discussions with them about this style of documentation.

@jkotas
Copy link
Member

jkotas commented Mar 16, 2020

The documentation I was talking about was the long form, blog post style docs

This type of documentation is there as well, e.g. https://docs.microsoft.com/en-us/dotnet/framework/unmanaged-api/profiling/profiling-overview

davmason added a commit to davmason/runtime that referenced this pull request Mar 16, 2020
davmason added a commit that referenced this pull request Mar 17, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
@davmason davmason deleted the stacksampling branch January 20, 2021 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants