-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions: Adding FileProviders and FileSystemGlobbing #33212
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3fc64b1
- [x] Bulk update all ref csproj except for FileProviders/FileSystemG…
maryamariyan 4424365
- Bulk move Descriptions to json file, all except for FileProviders a…
maryamariyan 77ffeef
- Bulk correct test project targetframeworks, all except for FileProv…
maryamariyan 20b4a94
- Bulk rename ref cs file and delete the extra duplicates
maryamariyan 358ea71
- Bulk move/rename Resources file
maryamariyan 7dba828
- [x] Enables ref/src/test/pkg on FileSystemGlobbing
maryamariyan 0313dcb
Enables ref/src on FileProviders projects
maryamariyan 7d685d4
For FileSystemGlobbing:
maryamariyan 87a17a7
Add packaging for M.E.FileProviders.*:
maryamariyan aa59a8b
Switch Reference to ProjectReference in ref proj
maryamariyan c1233d6
- Removed unnecessary helper files from src project
maryamariyan 259a0fb
Remove ParameterDefaultValue. As It was not needed.
maryamariyan 5c1cd5b
Fix common TestingUtils path
maryamariyan 1090288
Using PlatformSpecific instead of OSSkipCondition
maryamariyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
11 changes: 3 additions & 8 deletions
11
...ons.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,9 @@ | ||
<!-- This file is automatically generated. --> | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFrameworks>netstandard2.0;$(DefaultNetCoreTargetFramework)</TargetFrameworks> | ||
<TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
</PropertyGroup> | ||
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | ||
<Compile Include="Microsoft.Extensions.Configuration.Abstractions.netstandard2.0.cs" /> | ||
<Reference Include="Microsoft.Extensions.Primitives" /> | ||
</ItemGroup> | ||
<ItemGroup Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'"> | ||
<Compile Include="Microsoft.Extensions.Configuration.Abstractions.netcoreapp.cs" /> | ||
<ItemGroup> | ||
<Compile Include="Microsoft.Extensions.Configuration.Abstractions.cs" /> | ||
<Reference Include="Microsoft.Extensions.Primitives" /> | ||
maryamariyan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
</ItemGroup> | ||
</Project> |
64 changes: 0 additions & 64 deletions
64
...ration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.netstandard2.0.cs
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
11 changes: 3 additions & 8 deletions
11
...soft.Extensions.Configuration.Binder/ref/Microsoft.Extensions.Configuration.Binder.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,9 @@ | ||
<!-- This file is automatically generated. --> | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFrameworks>netstandard2.0;$(DefaultNetCoreTargetFramework)</TargetFrameworks> | ||
<TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
</PropertyGroup> | ||
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | ||
<Compile Include="Microsoft.Extensions.Configuration.Binder.netstandard2.0.cs" /> | ||
<Reference Include="Microsoft.Extensions.Configuration" /> | ||
</ItemGroup> | ||
<ItemGroup Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'"> | ||
<Compile Include="Microsoft.Extensions.Configuration.Binder.netcoreapp.cs" /> | ||
<ItemGroup> | ||
<Compile Include="Microsoft.Extensions.Configuration.Binder.cs" /> | ||
<Reference Include="Microsoft.Extensions.Configuration" /> | ||
</ItemGroup> | ||
</Project> |
26 changes: 0 additions & 26 deletions
26
...ions.Configuration.Binder/ref/Microsoft.Extensions.Configuration.Binder.netstandard2.0.cs
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...soft.Extensions.Configuration.Binder/src/Microsoft.Extensions.Configuration.Binder.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
...ensions.Configuration.Binder/tests/Microsoft.Extensions.Configuration.Binder.Tests.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
11 changes: 3 additions & 8 deletions
11
...sions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,9 @@ | ||
<!-- This file is automatically generated. --> | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFrameworks>netstandard2.0;$(DefaultNetCoreTargetFramework)</TargetFrameworks> | ||
<TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
</PropertyGroup> | ||
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | ||
<Compile Include="Microsoft.Extensions.Configuration.CommandLine.netstandard2.0.cs" /> | ||
<Reference Include="Microsoft.Extensions.Configuration" /> | ||
</ItemGroup> | ||
<ItemGroup Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'"> | ||
<Compile Include="Microsoft.Extensions.Configuration.CommandLine.netcoreapp.cs" /> | ||
<ItemGroup> | ||
<Compile Include="Microsoft.Extensions.Configuration.CommandLine.cs" /> | ||
<Reference Include="Microsoft.Extensions.Configuration" /> | ||
</ItemGroup> | ||
</Project> |
29 changes: 0 additions & 29 deletions
29
...guration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.netstandard2.0.cs
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
...sions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
...nfiguration.CommandLine/tests/Microsoft.Extensions.Configuration.CommandLine.Tests.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
11 changes: 3 additions & 8 deletions
11
...n.EnvironmentVariables/ref/Microsoft.Extensions.Configuration.EnvironmentVariables.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,9 @@ | ||
<!-- This file is automatically generated. --> | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFrameworks>netstandard2.0;$(DefaultNetCoreTargetFramework)</TargetFrameworks> | ||
<TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
</PropertyGroup> | ||
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | ||
<Compile Include="Microsoft.Extensions.Configuration.EnvironmentVariables.netstandard2.0.cs" /> | ||
<Reference Include="Microsoft.Extensions.Configuration" /> | ||
</ItemGroup> | ||
<ItemGroup Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'"> | ||
<Compile Include="Microsoft.Extensions.Configuration.EnvironmentVariables.netcoreapp.cs" /> | ||
<ItemGroup> | ||
<Compile Include="Microsoft.Extensions.Configuration.EnvironmentVariables.cs" /> | ||
<Reference Include="Microsoft.Extensions.Configuration" /> | ||
</ItemGroup> | ||
</Project> |
28 changes: 0 additions & 28 deletions
28
...ntVariables/ref/Microsoft.Extensions.Configuration.EnvironmentVariables.netstandard2.0.cs
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
...n.EnvironmentVariables/src/Microsoft.Extensions.Configuration.EnvironmentVariables.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...nmentVariables/tests/Microsoft.Extensions.Configuration.EnvironmentVariables.Tests.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
12 changes: 3 additions & 9 deletions
12
...Configuration.FileExtensions/ref/Microsoft.Extensions.Configuration.FileExtensions.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the curious (like me)
SA1129: DoNotUseDefaultValueTypeConstructor
SA1028: CodeMustNotContainTrailingWhitespace
SA1027: UseTabsCorrectly
SA1121: UseBuiltInTypeAlias
CA1200: Avoid using cref tags with a prefix
SA1000 : KeywordsMustBeSpacedCorrectly
CA1507: Use nameof in place of string
CA1802: Use Literals Where Appropriate
CA1825: Avoid zero-length array allocations
Most of these should be easy to come back and fix at once.