-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AzDO builds for iOS #33424
Add AzDO builds for iOS #33424
Conversation
Dang I meant to make this a draft |
667a43a
to
d82bb8f
Compare
@marek-safar on iOS only, or on OSX as well? |
ios only |
Well, this seems to be doing the expected thing? |
You need to hook up libraries build as well |
b79423c
to
d14e945
Compare
@marek-safar ok, looks like I wired in iOS Libraries. This still needs rebasing against the final version of #33292 but the AzDO logic seems sound |
d14e945
to
b9fbf71
Compare
OK, I rebuilt the branch against master post-merge. Let's see what happens |
Yeah that's looking OK. Ready for review I reckon. |
@directhex can you try doing an official build to make sure it works there too? |
@akoeplinger not until darc starts working again! |
Otherwise we expect CoreCLR to be available
2bb047b
to
fb12538
Compare
fb12538
to
b2b8991
Compare
@safern I can't reproduce the failure in the official build - https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/558857/logs/261 Suggestions? |
it seems like you're somehow missing an space in between iOS and -stripSymbols? I see this is how build-native.sh is being called. /Users/runner/runners/2.165.0/work/1/s/src/libraries/Native/build-native.sh x64 Release outconfig netcoreapp5.0-iOS-Release-x64 -os iOS-stripSymbols |
@safern I've figured out why that's happening, and could use input from @Anipik & @ViktorHofer to understand the right way to fix it (i.e. what the expected behaviour is supposed to be) In eng/pipelines/libraries/base-job.yml, the variable As a result, during command line construction in build-native.proj, Is the expectation that |
Arrgg I hate when that happens 😠 So I would leave Yes based on what @akoeplinger the expectation is that -stripSymbolsArg is empty for iOS. So I would also condition it when setting it in the yml to when osGroup != iOS. |
I guess same question to @akoeplinger, who added ios to the same conditional as wasm - should symbol stripping happen or not on iOS? |
OK, 'Mismatched MVIDs in ibc data' means nothing to me https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_apis/build/builds/561059/logs/288 |
I didn't really know which is why I just copied webassembly for now 😄 |
I think the answer is "no" because the symbol stripping depends on objcopy, which isn't available in this scenario |
Failures are unrelated, merging. |
This is based on #33292