Share managed EventSource/EventPipe implementation between CoreCLR and Mono. #33425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lateralusX
requested review from
akoeplinger,
alexischr,
CoffeeFlux,
EgorBo,
lambdageek,
lewurm,
marek-safar,
steveisok,
thaystg and
vargaz
as code owners
lateralusX
changed the title
marek-safar
reviewed
Mar 10, 2020
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventPipeEventProvider.cs
Outdated
Show resolved
Hide resolved
|
EventPipeEventDispatcher is depending on Interop.Kernel32.SetEvent PAL, currently not available on Mono none Windows platforms, causing build errors. Will look into alternatives, but most likely move logic down into EveptPipeInternal where we can do different implementations. Couple of build errors due to switching over to define instead of include/exclude for a couple of source files, will adjust those to be included/excluded based on features. |
lateralusX
changed the title
marek-safar
reviewed
Mar 10, 2020
...ono/netcore/System.Private.CoreLib/src/System/Diagnostics/Tracing/RuntimeEventSource.Mono.cs
Outdated
Show resolved
Hide resolved
lateralusX
force-pushed
the
lateralusX/tracing-support-monovm
branch
from
8cc2cc4
to
3bd00f3
Compare
sywhang
reviewed
Mar 10, 2020
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/RuntimeEventSource.cs
Show resolved
Hide resolved
josalem
reviewed
Mar 10, 2020
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs
Show resolved
Hide resolved
lambdageek
reviewed
Mar 10, 2020
src/mono/netcore/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventPipe.Mono.cs
Outdated
Show resolved
Hide resolved
filipnavara
approved these changes
Mar 11, 2020
noahfalk
approved these changes
Mar 12, 2020
src/coreclr/src/System.Private.CoreLib/src/System/Diagnostics/Eventing/EventPipe.CoreCLR.cs
Show resolved
Hide resolved
…d Mono. First changes needed in order to start sharing managed EventSource/EventPipe code between CoreCLR and Mono runtime. Sharable code has been moved into S.P.C library project and split into runtime specific source files when needed, kept within each runtime specific S.P.C project files. Mono runtime has been extended with a set of icalls needed by EventPipeInternal, just to make sure EventPipe can be initialized, current Mono runtime implementation returns dummy values. Current change also enables ETW provider support on Mono Windows runtime. NOTE, this is just initial changes needed in order to share managed EventSource/EventPipe code between runtimes. Future changes will incrementally add EventPipe native code into Mono runtime.
lateralusX
force-pushed
the
lateralusX/tracing-support-monovm
branch
from
3b25184
to
928542f
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First set of changes needed in order to start sharing managed EventSource/EventPipe code between CoreCLR and Mono runtime. Shareable code has been moved into S.P.C library project and split into runtime specific source files when needed, kept within each runtime specific S.P.C project files.
Mono runtime has been extended with a set of icalls needed by EventPipeInternal, just to make sure EventPipe can be initialized, current Mono runtime implementation returns dummy values.
Current change also enables ETW provider support on Mono Windows runtime.
NOTE, this is just initial changes needed in order to share managed EventSource/EventPipe code between runtimes. Future changes will incrementally add EventPipe native code into Mono runtime.