Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused and redundant msbuild properties in coreclr build #33645

Merged
1 commit merged into from
Mar 17, 2020
Merged

Delete unused and redundant msbuild properties in coreclr build #33645

1 commit merged into from
Mar 17, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 16, 2020

No description provided.

@@ -69,6 +69,7 @@
<LicenseFile>$(RepoRoot)LICENSE.TXT</LicenseFile>

<!-- Indicates this is not an officially supported release. Release branches should set this to false. -->
<!-- Keep it in sync with PRERELEASE in clrdefinitions.cmake -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #33636

@jkotas jkotas requested a review from safern March 16, 2020 19:45
@ghost
Copy link

ghost commented Mar 16, 2020

Hello @jkotas!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit f8fd577 into dotnet:master Mar 17, 2020
@jkotas jkotas deleted the msbuild-props-cleanup branch March 17, 2020 04:22
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants