-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement native GetModuleIndex #34997
Implement native GetModuleIndex #34997
Conversation
Thanks Jan for doing this. Should the "clr.buildtools" subset be removed now (eng\subsets.props) and the line in eng\pipelines\coreclr\templates\build-job.yml that builds it? And the GetModuleIndex tool source? I can do that clean if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good. Thanks Jan for doing this.
Ah, I knew I have forgotten something. Thank you for reminding me that. I'll add the cleanup to this PR. |
@mikem8361 I've removed the clr.buildtools stuff, can you please take a look one more time to make sure I've not forgotten anything? |
Some minor things that shouldn't be needed anymore. They are not that important to remove. eng/Versions.props line 80: remove <MicrosoftFileFormatsVersion>1.0.120601</MicrosoftFileFormatsVersion> src/coreclr/CMakeLists.txt line 28: remove CLR_DOTNET_COMMAND cmake property |
I've done that already. |
Thanks Jan. Looks good. |
1e3783c
to
0a9e95c
Compare
This change replaces managed GetModuleIndex tool by shell scripts using native tools.
86ad621
to
42ad5e5
Compare
This change replaces managed GetModuleIndex tool by shell scripts using
native tools.
Close #34920