-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GDI+1.1 API set in Windows 8 and later #35169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @safern, @tannergooding |
src/libraries/System.Drawing.Common/src/System/Drawing/GdiplusNative.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 18, 2020
This now depends on: dotnet/runtime-assets#72 |
jkotas
approved these changes
May 1, 2020
danmoseley
reviewed
May 1, 2020
src/libraries/System.Drawing.Common/src/System/Drawing/GdiplusNative.cs
Outdated
Show resolved
Hide resolved
danmoseley
approved these changes
May 1, 2020
ericstj
approved these changes
May 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some bug fixes that we can benefit from using GDI+ 1.1 in Windows. An internal customer reported transforming from wmf to png files was messing up the image and after speaking with the GDI+ team they said it was because we were using the 1.0 API set. Said it shouldn't be a big difference but some fixes like this should be exposed by using the new API set.