Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arcade from build 20200505.6 #35871

Merged
merged 6 commits into from
May 6, 2020
Merged

Conversation

safern
Copy link
Member

@safern safern commented May 5, 2020

We need to update arcade to unblock official builds due to: dotnet/arcade#5417 and also we need: dotnet/arcade#5415 in order to be able to update TFM from netcoreapp5.0 to net5.0.

Official build test: https://dev.azure.com/dnceng/internal/_build/results?buildId=632553&view=results

cc: @dotnet/runtime-infrastructure

@ghost
Copy link

ghost commented May 5, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern
Copy link
Member Author

safern commented May 5, 2020

cc: @riarenas @mmitche

@safern
Copy link
Member Author

safern commented May 6, 2020

@ViktorHofer I needed to rename the package testing settings dir to net5.0 to match the new TFM in package testing. We can drop this change and not update that package instead and update it in your PR if you want as well.

Also, it seems like updating arcade is blocked for installer builds that try to build the tests even when not wanting to run them using SkipTests=true property.

dotnet/arcade#5347 (comment)

We can stop building the tests for those cases instead on the meantime to consume arcade.

@ghost
Copy link

ghost commented May 6, 2020

Hello @ViktorHofer!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ViktorHofer ViktorHofer merged commit f4acc94 into dotnet:master May 6, 2020
@safern safern deleted the UpdateArcade branch May 6, 2020 15:01
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants