Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SslStream test for zero-byte reads #37128

Merged
merged 2 commits into from
May 31, 2020
Merged

Add SslStream test for zero-byte reads #37128

merged 2 commits into from
May 31, 2020

Conversation

stephentoub
Copy link
Member

We have higher-level tests for libraries like WebSockets that validate the behavior of zero-byte reads, but we don't currently have one in System.Net.Security's tests. Adding one.

Closes #37122
cc: @wfurt

@ghost
Copy link

ghost commented May 28, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

wfurt
wfurt approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is helper function you can use to simplify TCP connect.

src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamStreamToStreamTest.cs Outdated Show resolved Hide resolved
@davidsh davidsh added this to the 5.0 milestone May 28, 2020
@stephentoub
Add SslStream test for zero-byte reads
9fd0c2b 
We have higher-level tests for libraries like WebSockets that validate the behavior of zero-byte reads, but we don't currently have one in System.Net.Security's tests.  Adding one.
@stephentoub
Address PR feedback
502e169
@safern safern mentioned this pull request May 29, 2020
Closed
@stephentoub stephentoub merged commit baedfec into dotnet:master May 31, 2020
@stephentoub stephentoub deleted the ssl0read branch May 31, 2020 14:19
@jaredpar jaredpar mentioned this pull request Jun 1, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@halter73 halter73 halter73 approved these changes

@davidsh davidsh davidsh approved these changes

@wfurt wfurt wfurt approved these changes

Assignees
No one assigned
Labels
area-System.Net.Security
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Support 0 byte reads with SSLStream
5 participants
@stephentoub @halter73 @davidsh @wfurt @Dotnet-GitSync-Bot